Fix #3669: Treat java repeated arguments like scalac's #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java repeated arguments are now treated as scala repeated arguments. They are now replaced by a java array during ElimRepeated instead of Typer. This change let us Ycheck one more MegaPhase. Previously java repeated arguments would be replaced by a java array during typechecking which prevented us from retypechecking the tree: Array[T] found, expected T*
odersky
approved these changes
Dec 18, 2017
|
I think you may want to make a similar change in the unpickler: https://github.com/lampepfl/dotty/blob/88d016c6f0d991698a42bfca2d593f8ec1ae608d/compiler/src/dotty/tools/dotc/core/tasty/TreeUnpickler.scala#L949-L950 |
|
@smarter Is this code snippet meant to handle java repeated?
|
allanrenucci
referenced
this pull request
Dec 19, 2017
Remove dead code for unpickling java repeated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java repeated arguments are now treated as scala repeated arguments. They
are now replaced by a java array during ElimRepeated instead of Typer.
This change let us Ycheck one more MegaPhase. Previously java repeated
arguments would be replaced by a java array during typechecking which
prevented us from retypechecking the tree: Array[T] found, expected T*